[5.1] Fix some DB connection tests #15503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testTransactionsDecrementedOnTransactionException()
didn't actually test that the transaction level was decremented because the exception caused the test to end early.testCantSwapPDOWithOpenTransaction()
changed to use@expectedException
annotation, as is the convention, instead of$this->setExpectedException()
. Also, use$connection->setPdo(null)
instead of$connection->disconnect()
which aligns better with the intent of the test.